update mpt docs for permissioneddomains #3251
Conversation
mDuo13
left a comment
mDuo13
left a comment
There was a problem hiding this comment.
To be clear, this is set to go into rippled version 3.0.0, not version 2.6.0 which is the next planned release?
docs/references/protocol/transactions/types/mptokenissuancecreate.md
Outdated
Show resolved
Hide resolved
docs/references/protocol/transactions/types/mptokenissuanceset.md
Outdated
Show resolved
Hide resolved
Yes. Although the changes are in release 2.6.0, they are amendment gated by |
docs/references/protocol/transactions/types/mptokenissuancecreate.md
Outdated
Show resolved
Hide resolved
docs/references/protocol/transactions/types/mptokenissuanceset.md
Outdated
Show resolved
Hide resolved
docs/references/protocol/transactions/types/mptokenissuancecreate.md
Outdated
Show resolved
Hide resolved
docs/references/protocol/transactions/types/mptokenissuanceset.md
Outdated
Show resolved
Hide resolved
docs/references/protocol/transactions/types/mptokenissuanceset.md
Outdated
Show resolved
Hide resolved
| | `tecNO_DELEGATE_PERMISSION` | You are attempting to use a delegate account with insufficient permissions to submit this transaction. | | ||
| | `tecNO_DST` | The account specified in the `Holder` field doesn't exist. | | ||
| | `tecNO_PERMISSION` | - The `lsfMPTCanLock` flag isn't enabled, but you are attempting to lock or unlock an MPT.<br>- The `SingleAssetVault` amendment is disabled and you're trying to modify a `DomainID` field. | | ||
| | `temMALFORMED` | - You specified a `DomainID` and `Holder` value--only one can be set in a single transaction.<br>- You specified the same account for both `Acount` and `Holder`.<br>- The transaction isn't changing anything; it must either update a flag or modify the `DomainID`. | |
There was a problem hiding this comment.
temMALFORMED is a code that can occur for any transaction type.
| | `temMALFORMED` | - You specified a `DomainID` and `Holder` value--only one can be set in a single transaction.<br>- You specified the same account for both `Acount` and `Holder`.<br>- The transaction isn't changing anything; it must either update a flag or modify the `DomainID`. | |
There was a problem hiding this comment.
Same comment in issuancecreate. I think it's helpful to explain how you'd malform this specific transaction.
| | `temBAD_TRANSFER_FEE` | The transfer fee specified is greater than the maximum allowed value of 50,000. | | ||
| | `temDISABLED` | The `MPTokensV1` amendment is disabled. You will also receive this error if you include a `DomainID` field in the transaction, but the `PermissionedDomains` and `SingleAssetVault` amendments are both disabled. | | ||
| | `tecINSUFFICIENT_RESERVE` | The account creating the `MPTokenIssuance` ledger entry doesn't have enough XRP to meet the owner reserve. | | ||
| | `temMALFORMED` | - A non-zero transfer fee is set, but the `tfMPTCanTransfer` flag is _not_ set.<br>- The `DomainID` points to an invalid permissioned domain; you can also receive this error if you include a `DomainID` without setting the `tfMPTRequireAuth` flag.<br>- The `MPTokenMetadata` field is an invalid length (0 or exceeds 1024 bytes).<br>- The `MaximumAmount` field is 0 or exceeds 9,223,372,036,854,775,807 (2^63-1). | |
There was a problem hiding this comment.
temMALFORMED is one of the errors that can occur for any transaction type.
| | `temMALFORMED` | - A non-zero transfer fee is set, but the `tfMPTCanTransfer` flag is _not_ set.<br>- The `DomainID` points to an invalid permissioned domain; you can also receive this error if you include a `DomainID` without setting the `tfMPTRequireAuth` flag.<br>- The `MPTokenMetadata` field is an invalid length (0 or exceeds 1024 bytes).<br>- The `MaximumAmount` field is 0 or exceeds 9,223,372,036,854,775,807 (2^63-1). | |
There was a problem hiding this comment.
True, but I think it's helpful to explain what specifically you could be malforming to make it easier for someone to troubleshoot.
Maybe I could preface it with something like: "Besides generally malformed transactions, you can receive this error if ..."
Updated
MPTTokenIssuanceCreateandMPTokenIssuanceSettransaction docs to includeDomainIDfield. Also added additional error codes.Documents changes to MPT that are gated by Single Asset Vaults: XRPLF/rippled#5509